Expose full value object in `onSelectOption`

Alright I just got it all setup again and this was the issue…

<AutoCompleteItem
  key={idx}
  value={address}
  getValue={(address: AddressRecommendation) => address.address}
>
  {address.address}
</AutoCompleteItem>

The above works as expected, but when I select an item and set a debugger within onSelection, here’s what selectedOption is:

For my use case, I would expect selectedOption.item.value to be the full object so I could set the selected address and placeId, not just the value of the key I provided in getValue. Make sense? I wouldn’t make this change without getting input from others, especially since it’s a breaking change, but hopefully that clears up what my intent was.

_Originally posted by @SpencerKaiser in https://github.com/anubra266/choc-autocomplete/issues/60#issuecomment-1023484143_

[jcdogo]

In my opinion having the value in the item not match the value passed to AutoCompleteItem is sort of a bug. It’s confusing that they are not the same. One would expect that if you pass in a value you get the same value back when selected.

Although it’s a breaking change to change it to the full object, I think it’s the solution that makes the most sense in the long run.

However, looking at the code, the simplest solution is to just add an originalValue field to item that contains the original value object.

[jcdogo]

I don’t think that is a good idea to merge the objects. What if the full object already has a label and value field? Then you’ll have a key collision if you try to merge the fields from the full object into item.