apache-airflow-providers-google: google-ads-12.0.0

Hey team, I was looking to use the google ads hook but it seems like the google ads package is a bit out of date with the hook only taking “v5”, “v4”, “v3”, “v2” https://developers.google.com/google-ads/api/docs/release-notes and all of those being deprecated. Is there any chance the provider can be upgraded to include this? here is the release note of https://github.com/googleads/google-ads-python/releases/tag/12.0.0 google’s 12.0.0 release which also deprecated v5

Apache Airflow version: 2.0.1

What happened: deprecated API endpoint, need to update google ads to version 12.0.0

What you expected to happen: return query data, instead, I get an error returned from the google ads v5 API:

How to reproduce it: attempt to hit the v5 API endpoint

Anything else we need to know: error is below

Response
-------
Headers: {
  "google.ads.googleads.v5.errors.googleadsfailure-bin": "\nJ\n\u0002\b\u0001\u0012D Version v5 is deprecated. Requests to this version will be blocked.",
  "grpc-status-details-bin": "\b\u0003\u0012%Request contains an invalid argument.\u001a\u0001\nCtype.googleapis.com/google.ads.googleads.v5.errors.GoogleAdsFailure\u0012L\nJ\n\u0002\b\u0001\u0012D Version v5 is deprecated. Requests to this version will be blocked.",
  "request-id": "JyFZ9zysaqJbiCr_PX8SLA"
}
Fault: errors {
  error_code {
    request_error: UNKNOWN
  }
  message: " Version v5 is deprecated. Requests to this version will be blocked."
}

[irosario1999]

for sure!

[infused-kim]

The PR above makes the hook compatible with newer versions of the google-ads API.

The biggest breaking change in the google-ads API was that instead of returning results as native protocol buffers, it’s now returning the data in a simpler to use proto-plus format.

To ensure backwards compatibility for older operators that use the hook, I made the search() method convert the data back into native protocol buffers. In addition to that I added a search_proto_plus() method that returns the data in the new proto-plus format.

You can get more information about that here: https://developers.google.com/google-ads/api/docs/client-libs/python/library-version-10

Prioritization thoughts

Google completely stopped supporting the v5 API as of today. This means that the integrations of everyone who is using this hook are broken now.

So perhaps it’s worth considering to do an expedited release of the update to the google provider.