Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Description of defaultAirflowRepository in values.yaml is misleading

See original GitHub issue

Official Helm Chart version

1.5.0 (latest released)

Apache Airflow version

2.3.0 (latest released)

Kubernetes Version

minikube v1.25.2

Helm Chart configuration

No response

Docker Image customisations

No response

What happened

defaultAirflowRepository is described in values.yaml as

# Default airflow repository -- overrides all the specific images below
defaultAirflowRepository: apache/airflow

What you think should happen instead

defaultAirflowRepository doesn’t override the specific images, it is overridden by them. For example, in _helpers.yaml

{{ define "pod_template_image" -}}
{{ printf "%s:%s" (.Values.images.pod_template.repository | default .Values.defaultAirflowRepository) (.Values.images.pod_template.tag | default .Values.defaultAirflowTag) }}
{{- end }}

Suggest updating the comment line to:-

# Default airflow repository -- overridden by all the specific images below

How to reproduce

No response

Anything else

No response

Are you willing to submit PR?

Yes I am willing to submit a PR!

Code of Conduct

I agree to follow this project’s Code of Conduct

Issue Analytics

State:
Created a year ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

Dris101commented, Sep 15, 2022

Please do! I did submit a pull request but I think it slipped through the review net. Thank you!

0reactions

ihorlukianovcommented, Sep 15, 2022

Hello @potiuk, @Dris101 May I take this?

Top Results From Across the Web

airflow/values.yaml at main · apache/airflow - GitHub

Default values for airflow. # This is a YAML-formatted file. # Declare variables to be passed into your templates. # Provide a name...

Parameters reference — helm-chart Documentation

Parameter. Description. Default ... Default airflow repository. ... False. podTemplate. The contents of pod_template_file.yaml used for KubernetesExecutor ...

airflow 8.1.3 · airflow-helm/airflow-helm - Artifact Hub

There will always be a single default version of airflow shipped with this chart, see airflow.image.* in values.yaml for the current one.

stable/airflow · master · Lennart Nordgreen / helm-charts - GitLab

The default value is true, so if a user wants to add a password after the initial deployment, they should set scheduler.refreshConnections to...

chart - airflow - Git at Google

Parameter Description Default uid UID to run airflow pods under 50000 gid GID to run airflow pods under 50000 nodeSelector Node labels for pod assignment