Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve annotations customization in the chart

See original GitHub issue

Description

As discussed in https://github.com/apache/airflow/pull/13616#issuecomment-758234146, we would need to improve the customization of annotations across all objects of the chart.

Use case / motivation

We often need to paremetrize the annotations and we would rather do it in one PR with all the objects rather than one small PR everytime.

Are you willing to submit a PR?

@mik-laj I am ready to be assigned.

Related Issues Not to my knowledge.

What need to be tackled before starting dev:

On what objects do we want annotations?
What terminology do we choose in the values.yaml? (annotations or extraAnnotations or both or something else?)
Have a table with the mapping of each object and the value path for the annotation parametrization?
Should we drop the value airflowPodAnnotations ?

Issue Analytics

State:
Created 3 years ago
Comments:11 (11 by maintainers)

Top GitHub Comments

2reactions

mik-lajcommented, Jan 12, 2021

@dimberman @XD-DENG @potiuk Do you have any thoughts on this? I saw that these changes often come back in different forms, and I think we can do it once, but good.

1reaction

mik-lajcommented, Jan 29, 2021

We have a ticket that improves the annotation handling for SA a bit. Anyone willing to do a review and say if this change is sufficient for this ticket as well? https://github.com/apache/airflow/pull/11769