In 2.0.0b2/master, CLI "airflow connections add" is not handling invalid URIs properly

Apache Airflow version: 2.0.0b2

Environment: Docker

• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

What happened:

In current 2.0.0b2, airflow connections add is not handling invalid URIs properly.

For example, running CLI airflow connections add --conn-uri xyz conn_dummy will

• create the connection “conn_dummy” successfully (which should not be, IMO)
• in the connection created, it only has one attribute filled, which is “schema”, but the value added is “yz” (the value we provide is “xyz”, i.e., the 1st element is removed. because of https://github.com/apache/airflow/blob/master/airflow/models/connection.py#L213)

What you expected to happen:

In my opinion, a validation should be done first to ensure the conn-uri provided is valid (at least have “scheme” and “netloc” available in the urlparse result), and reject if it’s an invalid URI.

[jobegrabber]

@XD-DENG @kaxil I’m not sure if an error should be raised on a missing netloc since at least for Google Cloud connections it’s actually ignored: https://airflow.apache.org/docs/apache-airflow-providers-google/stable/connections/gcp.html#configuring-the-connection

This caused a regression for us when upgrading to Airflow 2 and setting up connections through the CLI. It took me a while to figure out what was causing the URI to become “invalid” - so this at least there should be a more precise warning about the actual part missing…

[kaxil]

Oh yes it should definitely raise an error