Task Group: Node order changes after collapse

Apache Airflow version: 2.0.0rc1

Kubernetes version (if you are using kubernetes) (use kubectl version):

Environment:

• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

What happened:

The order of the nodes changes when expanding and collapsing task groups: Before:

After expanding task group and collapsing:

What you expected to happen: node order to be consistent How to reproduce it:

Create a DAG with multiple task groups. expand the top group collapse the top group observe is is now at the end.

Anything else we need to know:

happens every time.

[kaxil]

@bbovenzi Can you take a look at this one when you have time please

[yuqian90]

@turbaszek Yeah, there is nothing wrong with the functionality. It’s just a tad annoying when things move around.

In fact, this isn’t an issue for TaskGroup specifically. Even before TaskGroup was introduced, simply refreshing the page can sometimes render the Graph View differently causing the nodes to shuffle around.

I can understand the pain. However, this issue needs to be addressed in the dependent package Dagre. I think this is the open issue upstream: https://github.com/dagrejs/dagre/issues/189

Unfortunately it doesn’t look like they are addressing it any time soon. Hopefully someone can come up with a workaround.