Add iPhone XR & iPhone XS Max splashscreens

Bug Report

Problem

What is expected to happen?

iPhone XR & iPhone XS Max splashscreens do get copied over if specified in config.xml

What does actually happen?

Images don’t get copied

root cause: prepare.js doesn’t include the new splash screen dimensions

Solution

Extend prepare.js

https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L428

-        { dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125 }
+        { dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125 },
+        { dest: 'Default-1792h.png', width: 828, height: 1792 },
+        { dest: 'Default-Landscape-1792h.png', width: 1792, height: 828 },
+        { dest: 'Default-2688h.png', width: 1242, height: 2688 },
+        { dest: 'Default-Landscape-2688h.png', width: 2688, height: 1242 }

Extend config.xml

+        <splash height="828" src="res/screen/ios/Default-Landscape-1792h.png" width="1792" />
+        <splash height="1792" src="res/screen/ios/Default-1792h.png" width="828" />
+        <splash height="2688" src="res/screen/ios/Default-2688h.png" width="1242" />
+        <splash height="1242" src="res/screen/ios/Default-Landscape-2688h.png" width="2688" />

In the generated project: Extend Contents.json

platforms/ios/AirSec/Images.xcassets/LaunchImage.launchimage/Contents.json

{
      "orientation": "portrait",
      "idiom": "iphone",
      "extent": "full-screen",
      "filename": "Default-2688h.png",
      "minimum-system-version": "12.0",
      "subtype": "2688h",
      "scale": "3x"
    },
    {
      "orientation": "landscape",
      "idiom": "iphone",
      "extent": "full-screen",
      "filename": "Default-Landscape-2688h.png",
      "minimum-system-version": "12.0",
      "subtype": "2688h",
      "scale": "3x"
    },
    {
      "orientation": "portrait",
      "idiom": "iphone",
      "extent": "full-screen",
      "filename": "Default-1792h.png",
      "minimum-system-version": "12.0",
      "subtype": "1792h",
      "scale": "2x"
    },
    {
      "orientation": "landscape",
      "idiom": "iphone",
      "extent": "full-screen",
      "filename": "Default-Landscape-1792h.png",
      "minimum-system-version": "12.0",
      "subtype": "1792h",
      "scale": "2x"
    },

Checklist

• I searched for existing GitHub issues
• I updated all Cordova tooling to most recent version
• I included all the necessary information above

[mobidev111]

I know about the legacy status & the better storyboard method.

I’d like consistency in the cordova-ios code base. So either:

• add the up-to-date set of images - for people still using it OR
• remove the managing code from the cordova-ios code / or clearly deprecate it as unmaintained

[jacobweber]

No problem – the docs are clear that the legacy approach is going away; I just wanted to make sure the “Single-image launch screen” approach isn’t. Thanks!