Problems with 5.1.1 and cordova-plugin-antitampering 0.4.2 - too many files in the release?
See original GitHub issueBug Report
Problem
I got an app that works perfectly with cordova-ios@5.0.1 and https://github.com/duddu/cordova-plugin-antitampering 0.4.2. I attempted to update cordova-ios to 5.1.1
What is expected to happen?
Everything works as expected (and as it did).
What does actually happen?
Antitampering blocks the app saying that
Anti-Tampering check failed! PathNotFoundException: No readable path retrieved for file cordova-js-src/.eslintrc.yml
Information
Looks like this file is present in 5.1.1 release, but not in 5.0.1; is that a release mistake (hence the file shouldn’t be included, and the problem is on cordova-ios), or should the file be added (hence the problem is on cordova-plugin-antitampering)?
Command or Code
Just build and run the app: it crashes due to expected behavior of antitampering plugin.
Environment, Platform, Device
iOS
Version information
Cordova 9 cordova-ios 5.1.1 cordova-plugin-antitampering 0.4.2
Checklist
- I searched for existing GitHub issues
- I updated all Cordova tooling to most recent version
- I included all the necessary information above
Issue Analytics
- State:
- Created 4 years ago
- Comments:8 (3 by maintainers)
Top GitHub Comments
Ah my bad, I think the error tripped me. Reading through the error again, it’s clear I originally misunderstood.
This was probably due to eslint changes that @erisu has been adding to each repo. Development config files such as the
.eslint.yml
file in my opinion, should not be included in the npm package since they have no purpose for the end user. The only files that should be packaged in the npm package are files that is necessary for the end user. This issue should be solved by https://github.com/apache/cordova/issues/113Actually I was to eager to ping random people. cordova-ios has not yet an
.npmignore
file. We are tracking it globally here: https://github.com/apache/cordova/issues/113@breautek as I read this issue, the file was added and was not present before