Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Statically prohibit missing format parameters in Druid's exception classes

See original GitHub issue

https://youtrack.jetbrains.com/issue/IDEA-175327 doesn’t allow to prevent bugs like fixed in #8331 using IntelliJ’s “Malformed format string” inspection. However, there is a simple workaround: make constructors in all Druid’s exception classes like RE, ISE, IAE, etc. private, expose static factory methods (e. g. RE.of()), and put them into the MalformedFormatString inspection config.

This would be a follow-up of #4474.

Issue Analytics

State:
Created 4 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

2reactions

leventovcommented, Aug 19, 2019

@ccaominh thanks for note, I’ve opened https://issues.apache.org/jira/browse/INFRA-18899

0reactions

ccaominhcommented, Aug 19, 2019

At least one apache project seems to have enabled lgtm github integration: https://issues.apache.org/jira/browse/INFRA-17226

lgtm github integration in action on apache geode:

Top Results From Across the Web

Statically prohibit missing format parameters in ... - GitHub

However, there is a simple workaround: make constructors in all Druid's exception classes like RE , ISE , IAE , etc. private, expose...

Make t() return a TranslationWrapper object to remove ...

Problem/Motivation. t() is one of the last places (other than SafeMarkup::format() ) where we still use the safe list.

MOTIF Frequently Asked Questions

SUN READERS *** The Motif FAQ is now included in a different HTML format with Java ... 105) How can I stop the...

review_comments.txt - GitHub

Use static final instead of hard-coded values There are no direct tests, ... Might now want to change the formatting :-) same as...

homebrew-core - Homebrew Formulae

a2ps 4.14 Any‑to‑PostScript filter aacgain 1.8 AAC‑supporting version of mp3gain aalib 1.4rc5 Portable ASCII art graphics library aamath 0.3 Renders mathematical expressions as ASCII art