Support direct comparisons between byte[] and Bytes

When comparing byte[] and Bytes, this currently requires an allocation and a copy. It would be nice to be able to do direct comparisons. To avoid copy+allocation, could possibly add the following methods to Bytes.

class Bytes {
   //note the method name contentEquals is used in String for types other than String
   public boolean contentEquals(byte[] bytes){...}
   public boolean contentEquals(byte[] bytes, int offset, int len){...}
   public int compareTo(byte[] bytes){...}
   public int compareTo(byte[] bytes, int offset, int len){...}
}

[keith-turner]

@jkosh44 you need to fork the apache repo, push your changes to your fork, and then create a pull request. You are trying to push to the apache repo instead of your forked repo. If you have already forked look into the git remote add command. Also look into pushing to specific remote.

https://help.github.com/articles/fork-a-repo/ https://help.github.com/articles/about-pull-requests/

[jkosh44]

Thanks, I missed that step. I made my fork, pushed my code, and a created pull request.