SharedZkClientFactory retains reference to closed ZkConnectionManagers

  // Close the ZkConnectionManager if no other shared client is referring to it.
  // Note the close operation of connection manager needs to be synchronized with the pool operation
  // to avoid race condition.
  private void cleanupConnectionManager(ZkConnectionManager zkConnectionManager) {
    synchronized (_connectionManagerPool) {
      zkConnectionManager.close(true);
    }
  }

Here, shouldn’t we remove closed references?

Need to remove this ZkConnectionManager from connectionManagerPool.

[narendly]

@manick02 Sure. If you want, you could submit a pull request with a commit and ask for a review.

[manick02]

If none has taken this issue, Can I look at this issue and submit a commit? This would help me understand helix better