Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow dropping a column used by old SortOrders

See original GitHub issue

Apache Iceberg version

1.0.0 (latest release)

Query engine

Spark

Please describe the bug 🐞

Here’s my first go at a PR for this, I did it on top of a 0.9 branch. I am willing to create a proper PR if that approach seems sound.

Repro:

CREATE TABLE temp.sort_order_col_ref_drop_test (a INT, b INT);
ALTER TABLE temp.sort_order_col_ref_drop_test WRITE ORDERED BY a;
ALTER TABLE temp.sort_order_col_ref_drop_test WRITE ORDERED BY b;
ALTER TABLE temp.sort_order_col_ref_drop_test DROP column a; -- FAIL

Exception stack trace:

java.lang.NullPointerException: Cannot find source column: 1
  at org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkNotNull(Preconditions.java:953)
  at org.apache.iceberg.SortOrder$Builder.addSortField(SortOrder.java:241)
  at org.apache.iceberg.TableMetadata.updateSortOrderSchema(TableMetadata.java:829)
  at org.apache.iceberg.TableMetadata.lambda$updateSchema$1(TableMetadata.java:460)
  at org.apache.iceberg.relocated.com.google.common.collect.Lists$TransformingRandomAccessList$1.transform(Lists.java:612)
  at org.apache.iceberg.relocated.com.google.common.collect.TransformedIterator.next(TransformedIterator.java:47)
  at org.apache.iceberg.TableMetadata.indexSortOrders(TableMetadata.java:891)
  at org.apache.iceberg.TableMetadata.<init>(TableMetadata.java:282)
  at org.apache.iceberg.TableMetadata.updateSchema(TableMetadata.java:464)
  at org.apache.iceberg.SchemaUpdate.commit(SchemaUpdate.java:369)
  at org.apache.iceberg.spark.SparkCatalog.commitChanges(SparkCatalog.java:448)
  at org.apache.iceberg.spark.SparkCatalog.alterTable(SparkCatalog.java:241)
  at ...