Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

StructLikeWrapper equals method is broken

See original GitHub issue

I ran into a situation when I had to check if two StructLikeWrapper are equal.
Those were results of some operations on partition schema (details here https://github.com/trinodb/trino/issues/12874) Their structs fields were different:

struct<1000: event_time_day: optional date, 1001: level: optional string>
struct<1001: level: optional string, 1002: event_time_hour: optional int>

Different types of fields resulted in IllegalArgumentException thrown from https://github.com/apache/iceberg/blob/a38e66323a99b65f433cb6e96007674a741a2f5a/core/src/main/java/org/apache/iceberg/util/StructLikeWrapper.java#L76

I think it should just return false instead of throwing an exception

Issue Analytics

State:
Created a year ago
Comments:7 (2 by maintainers)

Top GitHub Comments

2reactions

szehon-hocommented, Jun 21, 2022

Yea the trick is both StructLikeWrapper need the same type to compare. It may be risky to change it at this point?

@findinpath there’s a few prs on master fixing partitions table, not released yet, did you check with those? In particular #4560 and #4516 and #4637 (the first one being perhaps the more pertinent for this issue).

0reactions

alexjo2144commented, Jun 29, 2022

https://github.com/apache/iceberg/pull/5157