Hunspell affixes' file parsing corrupts some affixes' conditions

Hello!

Our hunspell aff file contains some rules for suffixes and prefixes that corrupt at the parsing. For example:

SFX AA a b [c]d

The condition [c]d is a correct regex expression but this rule does not work. The prblem is found in the hunspell dictionary class in the ParseAffix method (place in code).

We can see that if affix’s condition starts with [ and not ends with ] then the ] adds at the end of condition. So the condition become incorrect regex expression [c]d].

Maybe there the !condition.EndsWith("]", StringComparison.Ordinal) check should be replaced with the condition.IndexOf("]", StringComparison.Ordinal) == -1 check. But I don’t know about reasons of current version code. So I can be wrong.

[NightOwl888]

Great. I ran the tests in Lucene 4.8.0 and they fail, however in Lucene 8.2.0, they succeed. I checked the source, at least as far back as Lucene 4.10.4 the line in question was changed to use IndexOf just as you have suggested.

So, if we upgrade Lucene.Net.Hunspell to 4.10.4 as I proposed in #419, we will patch this problem automatically.

[SergeyKotyushkin]

Thanks. The test looks good, but it seems you didn’t attach the condition-issue-418.aff and .condition-issue-418.dic files.

Yes, I didn’t attach them but I wrote their content right in my comment.