Add exception to broker response when not all segments are available (partial response)
See original GitHub issueThere are 3 scenarios when the broker response might be partial:
- There are some segments without online server in external view -
numUnavailableSegments
inBaseBrokerRequestHandler
line 718 - Some segments are not available on server -
numSegmentsQueried > numSegmentsAcquired
inServerQueryExecutorV1Impl
line 170 - Some servers not responded -
numServersQueried > numServersResponded
inSingleConnectionBrokerRequestHandler
line 128
Currently these partial responses are only tracked by metrics/query stats, but not modeled as an exception. We should add an exception to the broker response to inform the users that the response might be partial
Issue Analytics
- State:
- Created 2 years ago
- Comments:22 (22 by maintainers)
Top Results From Across the Web
subject:"\[GitHub\] \[pinot\] suddendust ... - The Mail Archive
[GitHub] [pinot] suddendust commented on issue #7264: Add exception to broker response when not all segments are available (partial response).
Read more >Improve/Add completeness and freshness metrics for Pinot
Currently, we set a "partial-response" metadata flag when a broker is unable to get a connection to the server or response from a...
Read more >0.9.0 - Apache Pinot Docs
A new metrics plugin is added to support dropwizard. ... Add Exception to Broker Response When Not All Segments Are Available (Partial Response)...
Read more >Final Rule: Investment Adviser Marketing - SEC.gov
performance information would not qualify for the one-on-one exclusion unless provided in response to an unsolicited investor request or to ...
Read more >ENTRY SUMMARY ACCEPTANCE AND REJECTION POLICY
No duty or check attached and money is due (unless letter attached by broker stating entry summary submitted without payment). • The CSP...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
+1
I also suggest we change the default behavior to disallow partial response by default, and provide the flag to turn it on. In many use cases, data quality and correctness is a serious issue. So it’s ok to fail the query but not so to return a partial result silently.
I’d suggest adding different errors for each scenario described above to the
QueryException
, and users can decide on how to proceed based on the error type (error code). We already have similar errors such asBROKER_REQUEST_SEND_ERROR_CODE
which is added when a server cannot be reached