question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Modernizer] Apply modernizer plugin to pulsar-broker modules.

See original GitHub issue

Master issue: #12271

(2022-08-08 branch=master) I scan the broker, found 617 places to change. we need to split them into multiple PRs.

- src/main: 176
- src/test:  441
  - src/test/java/org/apache/pulsar/broker: 256
    - src/test/java/org/apache/pulsar/broker/admin: 116
  - src/test/java/org/apache/pulsar/client: 181
  - src/test/java/org/apache/pulsar/common: 4

i plan to log warn first, after modify completely, turn it to error.

      <plugin>
        <groupId>org.gaul</groupId>
        <artifactId>modernizer-maven-plugin</artifactId>
        <configuration>
<!--          <failOnViolations>true</failOnViolations>-->
          <failOnViolations>false</failOnViolations>
          <javaVersion>8</javaVersion>
<!--            <violationLogLevel>error</violationLogLevel>-->
          <violationLogLevel>warn</violationLogLevel>
        </configuration>
        <executions>
          <execution>
            <id>modernizer</id>
            <phase>verify</phase>
            <goals>
              <goal>modernizer</goal>
            </goals>
          </execution>
        </executions>
      </plugin>

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
tisonkuncommented, Oct 13, 2022

@MarvinCai @codelipenghui @nodece should be closed by #17968.

1reaction
youzipicommented, Aug 8, 2022

@MarvinCai @tisonkun @codelipenghui I will start from test .. broker/admin

Read more comments on GitHub >

github_iconTop Results From Across the Web

pulsar-client-auth-athenz - Sourcegraph
Enable CheckStyle Plugin in auth module (#13749)11 months ago. dd1a9e3. mc. Marvin Cai. Apply modernizer plugin to pulsar-client-autn pulsar-websocket and ...
Read more >
io.streamnative : pulsar-broker-auth-sasl : 2.11.0.0 ... - Maven Central
SASL authentication plugin for broker.
Read more >
Pulsar: pom.xml - Fossies
use okio version that matches the okhttp3 version --> 202 ... 246 <maven-modernizer-plugin.version>2.3.0</maven-modernizer-plugin.version> ...
Read more >
pom.xml · Gitee 极速下载/Pulsar - Gitee.com
<maven-modernizer-plugin.version>2.3.0</maven-modernizer-plugin.version>. <maven-shade-plugin>3.3.0</maven-shade-plugin>.
Read more >
modernizer-maven-plugin Joda Instant - java - Stack Overflow
Instant. I am not able to change the API of the class I am attempting to use. So, my question is how do...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found