question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PIP 176: Refactor Doc Bot

See original GitHub issue

PIP

PIP 176: Refactor Doc Bot to Improve Efficiency of Managing Doc

Issues (new)

  • P0: doc bot check is pending or waiting and documentation label check is changed to label check after it is set to required.

This blocks many PRs, eg. https://github.com/apache/pulsar/pull/16298, https://github.com/apache/pulsar/pull/16023

This might be caused by GitHub Action limitations https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

Can you please take a look at it at your earliest convenience? Thank you!

  • P1: when the PR description is empty and the PR author selects labels from Labels, the doc bot should work normally.

  • P2: configure the doc bot to other branches except for master - [x] 2.10. Obsever the results and set for other branches if it works well - [ ] 2.9 - [ ] 2.8 - [ ] 2.7

Issues can’t be resolved

Issues (old)

When fixing https://github.com/apache/pulsar/issues/15732, @maxsxu found that the doc Bot was implemented by modifying dist rather than src, which makes it hard to maintain and scale.

Consequently, he suggests refactoring the doc Bot along with resolving the following issues in Bot:

Scenario 1

Issue

This PR was marked with doc-related labels and then removed. No doc-related label is marked for this PR.

Expected behavior

In this case, this PR should be labeled w/ doc-label-missing.

image

Scenario 2

Issue

Doc Bot only works for master change.

Expected behavior

Doc Bot should work for all branches and label all PRs.

image

Scenario 3

Issue

Bot labels this PR with several doc labels.

Expected behavior

Bot should label a PR with only a doc label.

image

Improvements

Set documentation label check as one of the GitHub checks.

References

Pulsar Bot

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
Anonymitaetcommented, May 27, 2022

@maxsxu I’ve added more improvements as we discussed just now

1reaction
maxsxucommented, May 26, 2022

Thanks @Anonymitaet brings this out.

More context from the previous maintainer:

Current doc-label-check inspired from https://github.com/harupy/auto-labeling. During the doc bot development, just been modifying the compiled dist/index.js to quickly satisfy requirements.

So from all perspectives, refactoring is necessary. I’ll be working on this to make the doc Bot more maintainable and scalable.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Read the Docs Documentation
Read the Docs simplifies software documentation by building, versioning, and hosting of your docs, automatically. This enables many “docs ...
Read more >
Release history — Uproot documentation
PR #749: refactor: final refactoring for Forth generation. ... PR #203: Fixed #176 and made tests run in Python 2.7 (which is what...
Read more >
Release Notes - Typer - tiangolo
New docs for setting an epilog , with support for Rich Markdown and Console Markup, new docs: Commands - Command Help - Epilog....
Read more >
Buildbot 1.1.1 documentation
pip install --upgrade pip pip install buildbot-worker # required for `runtests` ... Buildbot includes an IRC bot that you can tell to join...
Read more >
openstack/ovsdbapp - ovsdbapp - OpenDev: Free Software Needs ...
176 Commits (96225836b0c289ca30493e77ee3d6683fce85bdd). All Branches ... 6 years ago. OpenStack Proposal Bot, 03ede4ec34 · Updated from global requirements
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found