question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consider to add @ToString annotation for SQLStatement and SQLSegment

See original GitHub issue

Feature Request

Is your feature request related to a problem?

No.

Describe the feature you would like.

According to the code conduct, each SQLStatement and SQLSegment implementation class must add the lombok @ToString annotation. If the implementation class inherits a parent class, you need to add the callSuper = true parameter.

At present, there are many SQLStatements and SQLSegments in the SQL Parser module without the @ToString annotation, which leads to the fact that when sql-show printing is enabled, only the address of the object can be printed, not the content of the object.

Therefore, we need to add @ToString annotations to SQLStatement and SQLSegment of different databases according to the specification——https://shardingsphere.apache.org/community/cn/contribute/code-conduct/.

  • Add @ToString annotation for common SQLStatement and SQLSegment
  • Add @ToString annotation for MySQL SQLStatement and SQLSegment
  • Add @ToString annotation for PostgreSQL SQLStatement and SQLSegment
  • Add @ToString annotation for openGauss SQLStatement and SQLSegment
  • Add @ToString annotation for SQLServer SQLStatement and SQLSegment
  • Add @ToString annotation for Oracle SQLStatement and SQLSegment
  • Add @ToString annotation for SQL92 SQLStatement and SQLSegment

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
Trydamerecommented, Jul 15, 2022

Hi @chakkk309, I will work on Oracle and SQL92 SQLStatement.

1reaction
chakkk309commented, Jul 15, 2022

Hi @Trydamere, I’m working on PostgreSQL, openGauss and SQLServer SQLStatement.

Read more comments on GitHub >

github_iconTop Results From Across the Web

[GitHub] [shardingsphere] Trydamere commented on issue #19189 ...
[GitHub] [shardingsphere] Trydamere commented on issue #19189: Consider to add @ToString annotation for SQLStatement and SQLSegment.
Read more >
@ToString - Project Lombok
Annotating a class with @ToString will cause lombok to generate an implementation of the toString() method. You use configuration options to specify whether ......
Read more >
Lombok's @ToString Annotation - Baeldung
Learn how to auto-generate the toString() method using Lombok ... We can annotate any class with the Lombok @ToString annotation.
Read more >
How to include fields in the @ToString annotation in Lombok
The @ToString annotation generates an implementation for the toString() method where the class name, along with each field in order, separated by commas, ......
Read more >
Code of Conduct - Apache ShardingSphere
Each SQLStatement and SQLSegment implementation class must add lombok @ToString annotation, if the implementation class inherits a parent class, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found