Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Task] refactor the places which maybe need muti values

See original GitHub issue

Description

Now ParameterData#builder has only one return value, which is not rigorous enough in some cases (such as cookieand header). You need to find these places (maybe not only ParameterData#builder has this problem) and refactor it. If you want to contribute or find places similar to ParameterData#builder, please leave a message and I will assign it to you.

Task List

- refactor org.apache.shenyu.plugin.base.condition.data.ParameterData#builder;
- refactor org.apache.shenyu.plugin.base.condition.data.HeaderParameterData;
- refactor org.apache.shenyu.plugin.base.condition.data.CookieParameterData;
- find places which maybe need muti values;

Issue Analytics

State:
Created a year ago
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

dragon-zhangcommented, Apr 26, 2022

@dragon-zhang I think we can consider tagging these issues as good second issues .

good idea

0reactions

dragon-zhangcommented, Apr 27, 2022

Sorry, guys, if this feature is merged now, it will cause some obvious performance loss. Therefore, I will close this issue.

Top Results From Across the Web

subject:"\[GitHub\] \[incubator\-shenyu\] dragon ... - The Mail Archive

[GitHub] [incubator-shenyu] dragon-zhang commented on issue #3346: [Task] refactor the places which maybe need muti values · 2022-04-27 Thread GitBox.

The best cloud migration strategy? It's not lift and shift - SHI Blog

Refactoring is not a simple solution. It takes time and patience. And it can't be done if your company isn't willing to buy...

Refactoring Task - an overview | ScienceDirect Topics

1. Removed unused code and function parameters · 2. Re-allocated and re-named packages, classes, functions, and fields · 3. Detected record default values...

Explaining Refactoring to Management - InfoQ

A sizable refactoring activity require slot in time and budget. It's always better for a team leader to be aware of the cost...

Refactoring a Batch or Object with SQL Prompt | Redgate

Highlight Cities$List , right-click and choose Inline Exec. The parameters of the procedure will be transformed into variables, and the variable ...