Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Volunteer] Improve unit test coverage of shenyu-common

See original GitHub issue

Volunteer help

As a branch of #3274 .

At present, the test coverage of shenyu-common module is not high. Please try to make the test coverage of each class reach more than 80% (in the case of ensuring the stability of the test).

If you would like to help, please leave a message under this issue. BTW, you can use Run 'Test in 'xxx'' With Coverage in IntelliJ IDEA to see the approximate coverage.

PS: If the modified code is too much, it can be divided into several pr submissions.

org.apache.shenyu.common.cache @selectbook
org.apache.shenyu.common.concurrent @Albertsirius
org.apache.shenyu.common.config @Nick-fengzl
org.apache.shenyu.common.dto @luoweijr
org.apache.shenyu.common.timer @jun0315
org.apache.shenyu.common.utils (maybe a large job) @zhangcly

Issue Analytics

State:
Created a year ago
Comments:14 (12 by maintainers)

Top GitHub Comments

1reaction

selectbookcommented, May 28, 2022

@JooKS-me @selectbook Hi, I see org.apache.shenyu.common.cache is no complete, can I take this task?

@MichaelDeSteven Hi, I found the cache package unnecessary to enhance the test. You can find small packages that need to improve test coverage in https://app.codecov.io/gh/apache/incubator-shenyu, and then create an issue to indicate what you want to do. Generally, we need to increase the test coverage to 80%. BTW, ping @jun0315 @zhangcly, are you still doing it?

Sorry, I find it a little difficult. Please assign this task to others.

@JooKS-me I will try to finish the task of org.apache.shenyu.common.timer

1reaction

JooKS-mecommented, May 22, 2022

@JooKS-me @selectbook Hi, I see org.apache.shenyu.common.cache is no complete, can I take this task?

@MichaelDeSteven Hi, I found the cache package unnecessary to enhance the test. You can find small packages that need to improve test coverage in https://app.codecov.io/gh/apache/incubator-shenyu, and then create an issue to indicate what you want to do. Generally, we need to increase the test coverage to 80%.

BTW, ping @jun0315 @zhangcly, are you still doing it?

Top Results From Across the Web

[GitHub] [incubator-shenyu] luoweijr commented on issue #3275 ...

... on issue #3275: [Volunteer] Improve unit test coverage of shenyu-common ... and pick the package of org.apache.shenyu.common.dto -- This is an automated ......

Improving Test Coverage - Semantic Designs

The usual way to increase covered code answer is "code more tests" that exercise additional code. To minimize test coding effort, you want...

What is unit testing? How to improve your test coverage in Java

Short video introduction into why unit testing is important, what it is, and how you can easily improve test coverage in your Java...

شاحنة تفريغ الرمل والحصى Dongfeng Shenyu

[Volunteer] Improve unit test coverage of shenyu-common good first issue in: test level: medium status: volunteer wanted. #3275 opened on Apr 18 by...

How to Efficiently Increase Unit Test Coverage in Java

A lot of engineering managers dismiss this question because they know the answer: either have your team write more tests in between new...