CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1

App routing is broken in the latest release with respect to Custom Security Manager. Please deprecate this release.

Expected results

When attempting to access the root url for Superset, this should redirect to the login page if the user is not logged in. This redirect is failing to work when AUTH_TYPE = AUTH_OID

Actual results

The app routes to /superset/welcome

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

1. Use a custom security manager, akin to https://stackoverflow.com/questions/54010314/using-keycloakopenid-connect-with-apache-superset#54024394
2. Deploy
3. Navigate to bare url

Environment

(please complete the following information):

• superset version: 0.34.0rc1
• python version: 3.6
• node.js version: 10.0
• npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven’t found one similar.

Additional context

This works perfectly fine on 0.33.0rc1, so I have had to downgrade. Because of this issue, where the routing is not correct, I believe this issue should be resolved and 0.34.0rc1 should be pulled.

[villebro]

App routing is broken in the latest release with respect to Custom Security Manager. Please deprecate this release.

IMO, the 0.34 release has a good deal of bug fixes/improvements that merit releasing 0.34 rather than 0.33. As 0.34 will (hopefully) become the first official ASF Superset release, there will for sure be many bugs that surface as people try it out. Rest assured committers (myself included) will give reported issues high priority to make sure that bugs are ironed out of the 0.34 branch (along with master) as quickly as possible.

[mmutiso]

Hi @ericandrewmeadows ,

We had the same issue as explained in that StackOverflow question although we are using a different openId connect provider called IdentityServer4.

We, therefore, did a custom security manager that does the integration by extending the superset security manager. I would be happy to provide my approach if need be. It involved a little bit of code and understanding of the workings of openId connect(built on top of OAuth2)