Do we really need four different Python linters?

The rules often conflict with each other on things like import order or how you should break up long lines, leading to disable comments scattered all over the codebase and a lack of cohesive code style. How would folks feel about switching to just one?

[mistercrunch]

Did you setup pre-commit? https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#git-hooks

It checks only touched files so it’s fast (pylint is super slow to run across the codebase)

About pylint vs flake8: pylint is dynamic so it can do things flake8 (static analysis) will probably never do. Things like method signatures matching over inheritance, code complexity checks, number of arguments too high, … It’s old and clunky but somewhat powerful. We can disable checks we don’t like.

black and flake8 had lots of overlap and some conflicts. It made sense to kill flake8

mypy is type checking, different purpose, we should enable in pre-commit if possible

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.