Elasticsearch connection got problem when click test connection

A clear and concise description of what the bug is.

Expected results

what you expected to happen. elasticsearch+http://elastic:changeme@device1:9200 I added the above url as the ES connection

Actual results

But it failed with an Error:

ERROR: {"error": "Connection failed!\n\nThe error message returned was:\ncan only concatenate str (not \"NoneType\") to str", "stacktrace": "Traceback (most recent call last):\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/superset/views/core.py\", line 1704, in testconn\n    with closing(engine.connect()) as conn:\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 2206, in connect\n    return self._connection_cls(self, **kwargs)\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 103, in __init__\n    else engine.raw_connection()\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 2306, in raw_connection\n    self.pool.unique_connection, _connection\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py\", line 2275, in _wrap_pool_connect\n    return fn()\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py\", line 303, in unique_connection\n    return _ConnectionFairy._checkout(self)\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py\", line 760, in _checkout\n    fairy = _ConnectionRecord.checkout(pool)\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py\", line 492, in checkout\n    rec = pool._do_get()\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/impl.py\", line 238, in _do_get\n    return self._create_connection()\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py\", line 308, in _create_connection\n    return _ConnectionRecord(self)\n  File \"/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/...

This is the log:

TypeError: can only concatenate str (not "NoneType") to str
2020-01-04 18:44:27,311:INFO:werkzeug:127.0.0.1 - - [04/Jan/2020 18:44:27] "POST /superset/testconn HTTP/1.1" 500 -
2020-01-04 18:48:03,388:INFO:root:Database.get_sqla_engine(). Masked URL: elasticsearch+http://elastic:XXXXXXXXXX@device1:9200
2020-01-04 18:48:03,389:ERROR:root:can only concatenate str (not "NoneType") to str
Traceback (most recent call last):
  File "/data/software/miniconda3/lib/python3.7/site-packages/superset/views/core.py", line 1704, in testconn
    with closing(engine.connect()) as conn:
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2206, in connect
    return self._connection_cls(self, **kwargs)
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 103, in __init__
    else engine.raw_connection()
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2306, in raw_connection
    self.pool.unique_connection, _connection
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 2275, in _wrap_pool_connect
    return fn()
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 303, in unique_connection
    return _ConnectionFairy._checkout(self)
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 760, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 492, in checkout
    rec = pool._do_get()
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/impl.py", line 238, in _do_get
    return self._create_connection()
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 308, in _create_connection
    return _ConnectionRecord(self)
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 437, in __init__
    self.__connect(first_connect_check=True)
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/pool/base.py", line 639, in __connect
    connection = pool._invoke_creator(self)
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/strategies.py", line 114, in connect
    return dialect.connect(*cargs, **cparams)
  File "/data/software/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 453, in connect
    return self.dbapi.connect(*cargs, **cparams)
  File "/data/software/miniconda3/lib/python3.7/site-packages/es/elastic/api.py", line 32, in connect
    return Connection(host, port, path, scheme, user, password, context, **kwargs)
  File "/data/software/miniconda3/lib/python3.7/site-packages/es/elastic/api.py", line 109, in __init__
    **kwargs,
  File "/data/software/miniconda3/lib/python3.7/site-packages/es/baseapi.py", line 57, in __init__
    self.url = parse.urlunparse((scheme, netloc, path, None, None, None))
  File "/data/software/miniconda3/lib/python3.7/urllib/parse.py", line 475, in urlunparse
    return _coerce_result(urlunsplit((scheme, netloc, url, query, fragment)))
  File "/data/software/miniconda3/lib/python3.7/urllib/parse.py", line 487, in urlunsplit
    url = '//' + (netloc or '') + url
TypeError: can only concatenate str (not "NoneType") to str

what actually happens.

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

1. Go to ‘…’
2. Click on ‘…’
3. Scroll down to ‘…’
4. See error

Environment

(please complete the following information):

• superset version: superset version Superset 0.35.1
• python version: python --version Python 3.7.3
• node.js version: node -v
• npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven’t found one similar.

Additional context

I already installed pip install elasticsearch-dbapi

Add any other context about the problem here.

[dpgaspar]

Please try with the following connection string instead:

elasticsearch+http://elastic:changeme@device1:9200/

Notice the trailing slash, I’ll improve this on elasticsearch-dbapi

[dpgaspar]

no problem