Inconsistent Behavior for CRUD view modals

Screenshot

Description

In the new React-based Dashboard & Chart CRUD view. The edit modal has animation on both opening and closing, but the edit modal has only opening animation.

Also, I think we should probably consider linking the edit button to opening <dashboard_url?>edit=true in a new window instead of opening the properties modal, because it’s much more commonly needed to edit the dashboard layout/charts rather than just the things in properties modal.

Design input

[describe any input/collaboration you’d like from designers, and tag accordingly. For design review, add the label design:review. If this includes a design proposal, include the label design:suggest]

[nytai]

Let’s have a conversation here (@junlincc @lilykuang @benceorlai @eschutho @mistercrunch ) about switching over the edit action on the dashboard list view.

Current the edit action only open the dashboard properties modal. Should we just make the call that “Editing a dashboard means opening the dashboard in edit mode and not opening the dashboard properties modal”? It seems that everyone I’ve talked to advocates for

linking the edit button to opening <dashboard_url?>edit=true in a new window instead of opening the properties modal, because it’s much more commonly needed to edit the dashboard layout/charts rather than just the things in properties modal.

I think this should clear up a number of bugs/cosmetic issues around the current dashboard edit experience. Does anyone feel differently?

[nytai]

Looks like the portion about the strange saving behavior on the properties modal is covered by https://github.com/apache/incubator-superset/issues/11677