Owner names not rendered in React Datasource editor
See original GitHub issueExpected results
The dataset owners should be rendered.
Actual results
How to reproduce the bug
- Go to a chart.
- Click on ‘Edit Datasource’
- Click on the ‘SETTINGS’ tab
- Scroll to the bottom and and noticed that the owner names aren’t rendered
Environment
(please complete the following information):
- superset version:
master
- python version:
3.7
- node.js version:
12
Checklist
Make sure to follow these steps before submitting your issue - thank you!
- I have checked the superset logs for python stacktraces and included it here as text if there are any.
- I have reproduced the issue with at least the latest released version of superset.
- I have checked the issue tracker for the same issue and I haven’t found one similar.
Issue Analytics
- State:
- Created 3 years ago
- Comments:32 (31 by maintainers)
Top Results From Across the Web
Owner names not rendered in React Datasource editor #11680
Go to a chart. Click on 'Edit Datasource'; Click on the 'SETTINGS' tab; Scroll to the bottom and and noticed that the owner...
Read more >Unknown Prop Warning - React
The unknown-prop warning will fire if you attempt to render a DOM element with a prop that is not recognized by React as...
Read more >General Props | Docs and API Reference - React Data Grid
If not present, column.name will be used (after it's upper-cased and humanized) as the column header. render - a render function in order...
Read more >A comprehensive guide to data fetching in React
There is a variety of ways to fetch data in React, including using the inbuilt Fetch API, Axios, and more. We'll go over...
Read more >Walkthrough: Creating a simple rendering with a data source
Your rendering host page outputs Unknown component or a similar message, because you have not yet mapped a component to this JSON rendering...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@junlincc I’m going to see if the issue is present in our internal weekly deploy which occurs on Wednesday. If it’s resolved it’s likely our last week branch cut did not contain the commit and I’ll close the issue, otherwise I’ll dig into this in more detail.
@etr2460 I don’t think my current implementation would work for the Datasource settings specifically. You can check the code in this PR https://github.com/apache/superset/pull/16609 that is related to the owners in the Datasource settings. Basically, we would need a refactor of the
SelectAsyncControl
to work with the pagination. That PR is not merged yet so this might be a good opportunity to think about doing it, depending on prioritization OR we can increase the pagesize to a high limit as a quick fix as suggested above. CC @junlinccThere is another implementation which is using the paginated fetch instead and that’s in the Properties modal. I have an env with more than 10 owners (10 as a pagesize limit) and could not spot any problem. I am about to merge this PR containing the changes. This can be a good opportunity to validate this issue against the new implementation https://github.com/apache/superset/pull/16445.