Owner selectors sometimes display full name, other times username

The Edit Dashboard and Edit Chart modals display the user’s full name when selecting an owner from the dropdown, but display the username when simply displaying the existing owners.

The cause of this is that the /dashboard/related/owners api endpoint returns full name, while the /dashboard/:id endpoint returns only the username, so the modal is just using the information that it has available. Both endpoints return the user id, so this doesn’t lead to real bugs, just visual confusion. I think the best solution would be for the endpoints to return more information, but I’m unsure how to accomplish that within FAB. Open to other suggestions as well.

Pinging @dpgaspar for FAB expertise.

Expected results

Should use the owner’s name

Actual results

Mixed results

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

1. Go to a chart or a dashboard
2. Click on “edit properties” to open the edit modal
3. Set some owners
4. Reload the modal, owners are now displayed by username instead of name

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven’t found one similar.

[nytai]

@suddjian These are the fields for the /dashboard/:id endpoint https://github.com/apache/incubator-superset/blob/master/superset/views/dashboard/api.py#L144

This is the /related/:col_name endpoint https://github.com/apache/incubator-superset/blob/master/superset/views/base_api.py#L132

[suddjian]

This was fixed a while ago