question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Pass over dashboard and chart IDs to DB_CONNECTION_MUTATOR

See original GitHub issue

Is your feature request related to a problem? Please describe. Right now all superset queries have the same source of SQL_LAB, EXPLORE or DASHBOARD. We are encountering many issues with single poorly written dashboards/widgets stalling the whole Presto cluster. The industry standard for fixing this is providing more granular source information, like dashboard and widget ID, so dev ops can easily track offenders. Right now we have to resort to roll calling in our data science Slack channel asking if anyone has added a particular query to the dashboard.

Describe the solution you’d like I want to extend the DB_CONNECTION_MUTATOR function API to accept a dictionary of additional source information like dashboard ID, chart/widget ID, so this configurable function cat assemble an appropriate Presto connection. This feature can be as well used for other databases as well. Presto stands here as a prime example which our team has to deal with.

Describe alternatives you’ve considered I’ve considered accessing Flask’s request directly from the DB_CONNECTION_MUTATOR in order to extract the necessary data, but I found that some queries run asynchronously through Celery, where the request information is lost.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
nytaicommented, Aug 4, 2021

Looks like some info is already passed in https://github.com/apache/superset/blob/11a2d4dfdd42bed78c913d0b2b1563e077425acf/superset/models/core.py#L363

Adding a context param to the function signature seems like it could cover future use cases as well.

1reaction
nytaicommented, Aug 4, 2021

This sounds reasonable, I think it’s at least worth opening up a PR to your upstream.

Read more comments on GitHub >

github_iconTop Results From Across the Web

superset/config.py at master · apache/superset - GitHub
# Grant public role the same set of permissions as for a selected builtin role. # This is useful if one wants to...
Read more >
Controls and Dashboards | Charts - Google Developers
On this page, you'll see how to combine multiple charts into dashboards and give users controls to manipulate what data they show.
Read more >
Manage your dashboard | New Relic Documentation
Access any of your New Relic dashboards to create or manage your charts directly from the chart menu, customize your dashboard's layout, adjust...
Read more >
Cross-filtering dashboards | Looker - Google Cloud
With cross-filtering, users can click a data point in one dashboard tile to have all dashboard tiles automatically filter on that value.
Read more >
Custom destinations: choose what happens when people click ...
Go to a custom destination. Link to the Product Detail dashboard. Pass the value from the Product ID column to the ID filter...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found