[prophet] prophet installation fails with ModuleNotFoundError: No module named 'lunarcalendar'

How to reproduce the bug

Following methods to install prophet on docker image of Superset 1.5.1 fails with ModuleNotFoundError: No module named ‘lunarcalendar’

docker pull apache/superset:1.5.1 docker run -it <imageid> bash pip install apache-superset[prophet] pip install --no-cache-dir apache-superset[prophet] pip install prophet==1.0.1 pip install --no-cache-dir prophet==1.0.1

Note that the missing dependency can be anything, depending of what it is already installed or not, I personally saw errors about missing lunarcalendar, pystan, tqdm. Same has been explained here

For me, this worked finally: pip install lunarcalendar tqdm "pystan<3.0" && pip install "prophet>=1.0.1, <1.1" but i think even this might break in future if version of any of the other common dependencies with superset are changed or dependency is removed altogether.

Note: prophet dependency issues were solved recently in 1.1 release. I can install latest 1.1 prophet package with pip install prophet without errors but holidays package gets upgraded and then superset db upgrade breaks and gives below error. pkg_resources.ContextualVersionConflict: (holidays 0.14.2 (/usr/local/lib/python3.8/site-packages), Requirement.parse(‘holidays==0.10.3’), {‘apache-superset’}) pkg_resources.DistributionNotFound: The ‘holidays==0.10.3’ distribution was not found and is required by apache-superset

Can holidays package dependency be bumped to 0.14.2 in Superset ?

Expected results

It should be easy to install prophet

Actual results

its really messy

Screenshots

Here are the logs:

prophet-latest-directly.txt prophet-via-setup-py.txt prophet-1.0.1-directly.txt

Environment

• browser type and version: NA
• superset version: 1.5.1
• python version: 3.8.13
• node.js version: NA
• any feature flags active: NA

Checklist

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven’t found one similar.

Additional context

[wiktor2200]

With this Dockerfile:

FROM apache/superset:2.0.0 AS superset
USER root

RUN rm -rf /var/lib/apt/lists/* && \
    pip install \
        Authlib==1.0.1 \
        flask-oidc==1.3.0 \
        psycopg2-binary==2.9.1 \
        redis==3.5.3

## Install prophet and dependencies - there is open issue on Github: https://github.com/apache/superset/issues/20901
RUN pip install \
        lunarcalendar==0.0.9 \
        tqdm==4.64.0 \
        pystan==2.19.1.1   
RUN pip install prophet==1.0.1

USER superset

I was able to build Superset with prophet, but it still doesn’t work. I’m having the same problem as above, no more errors, but forecast always returns 0 rows. I’ve tried with both 2.0.0 and 1.5.1.

[mdeshmu]

This is what i have exactly in my Dockerfile.

RUN pip install --upgrade pip RUN pip install lunarcalendar tqdm “pystan<3.0” && pip install “prophet>=1.0.1, <1.1”