[SIP] Proposal for Implemention of dynamic theme in superset
See original GitHub issueMotivation:
Supporting dynamic theme in superset will provide end-user to use his/her choice of theme on the go.
Proposed Change:
1> Provide option to change theme from UI. 2> Support of multiple themes 3> Separate theme-able style from other styles (position, size etc) 4> use scss/less mixin to change theme dynamically
this is how the style for any component will look like:
`.btn-primary { width: 200px; Padding: 2px; position: relative;
}
@mixin btn-primary-theme($theme) {
.btn-primary {
color: get-color($theme, primary); background-colour: get-color($theme, background); font-size: font-size($theme, button); }
} `
New or Changed Public Interfaces:
-
if we use SCSS mixin the we need sass-loader (MIT license) Enable scss style pre-processor in superset.
-
If we use less. Since Less is already supported in superset, don’t need any change
Migration Plan and Compatibility
for backward compatibility existing styles will be available. To use theme user need to use new styles
Issue Analytics
- State:
- Created 5 years ago
- Reactions:3
- Comments:6 (6 by maintainers)
Top GitHub Comments
@rasmi-ranjan-guavus @mistercrunch MVP proposal using existing CSS Templates: https://github.com/gbrian/incubator-superset/pull/2
Since this issue is closed, we’ll also consider the SIP/proposal process closed as well. If you want to rekindle this proposal, please re-open this Issue, and send a new [DISCUSS] thread to the dev@ mailing list. Thank you!