Slice and Dashboard lists don't respect `database` and `schema`-related perms

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if any
• I have reproduced the issue with at least the latest released version of superset
• I have checked the issue tracker for the same issue and I haven’t found one similar

Superset version

Latest

Expected results

When database access on [db].(id:#) is granted to a role, it should have the effect of also granting datasource access on all data sources in the DB. Per https://superset.incubator.apache.org/security.html - “Database: Granting access to a database allows for the user to access all data sources within that database”

Actual results

It does not grant data source access. In order to grant data source access, the datasource_access permission has to be granted for each table in the DB.

Steps to reproduce

1. Fresh install the current version of Superset
2. Create new role, “Main”, add database_access on [main].(id:1)
3. Create new user with “Gamma” and “Main” roles
4. Log in as new user

Notes

This is similar to #3085 but that issue was closed, and this issue is reproducible from a fresh install. The tables are accessible if datasource access is granted for each table, but in my DB, there are hundreds of tables and I’d prefer to not have to manually add each one as a permission. I’d be happy to investigate too if someone pointed me in the right direction.

[rumbin]

@mistercrunch: It seems that this issue is still present, at least in Superset 0.34.1. I also do not see why this issue had been closed, as there is no link to any PR or any stale-bot interaction.

Would you mind reopening it?

[grbinho]

I’m seeing the same behaviour with the latest image from https://hub.docker.com/r/preset/superset/