Source tab on Edit Dataset modal inconsistent with Datasource on Chart Explore view

~1week ago a change was merged redesigning the modal “Edit Datasource” on Chart Explore. It is not clear what should be the behavior of the section Source on Edit Dataset:

Context

Use case 1: Changing datasource using Change Datasource This change is local - only for the chart user has open. This works as expected.

Use case 2: Changing datasource using Edit Datasource --> Source Previously the Source tab was last on the right side, merged with settings. It’s unclear what is changing the source on this modal supposed to do. Typically, any changes to “Edit Datasource” are applied globally to ALL CHARTS using the datasource. User is warned about this. What is changing the source on the 1st tab actually supposed to do?

Current behavior:

Currently, if you change the name of table (Datasource) nothing happens.

After saving the change nothing happens to the chart, and the changes are not saved when opening the modal again.

Expected behavior:

Unclear. If this is another way to change datasource LOCALLY for the one chart, (1) the warning shouldn’t be displayed and (2) the change should apply to the current chart. This change should not apply globally to all charts.

How to reproduce the bug

1. Go to Chart Explore
2. Click on Edit Datasource
3. On 1st tab (Source) change the name of table
4. Save
5. Nothing happens

Environment

• superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven’t found one similar.

[junlincc]

I agree that this functionality is a bit redundant and if we keep it modal, the warning message should be either louder and more specific. Zuzana, let’s explore a better solution after getting the bug fix. Thanks for suggesting!

On Wed, Oct 14, 2020 at 9:39 AM zuzana-vej [e-mail] wrote:

So basically editing dataset on the edit dataset modal (screenshot in my previous message) will be applied locally to the chart. It’s just another way to do it (in case user is already on the modal). I think that makes sense. I question whether it’s necessary to have this here, since user can do it via Change Datasource.

And if we keep this functionality on this modal, the warning message whey you are saving the change needs to change. Currently it says that “all changes will be applied to all charts” which is true if you edit Metrics, Columns or Calculated columns. But message should be different if you just edit datasource which is only applied to this chart (warning user that this chart might break if their new datasource doesn’t include same columns, but not warning user about other charts)

[image: Screen Shot 2020-10-14 at 9 36 48 AM] https://user-images.githubusercontent.com/61221714/96019207-10877100-0e01-11eb-85db-a76216ca6fd2.png [image: Screen Shot 2020-10-14 at 9 36 56 AM] https://user-images.githubusercontent.com/61221714/96019212-13826180-0e01-11eb-91c7-f9c542a02285.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache/incubator-superset/issues/11190#issuecomment-708521731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFR5U67MUHECJCDOWTO2FDSKXH3NANCNFSM4SHWCEXA .

[zuzana-vej]

Closing this as we had some discussions and this bug is resolved. There is a new different bug - raising new issue for tracking.