SQL Lab saved query appears as "untitled" in new SQL Lab window

When user saves a SQL Lab query, and then opens a new browser tab and loads SQL Lab (or closes browser and opens SQL Lab again later), the earlier saved query is labeled as “untitled query”. The query is however saved and view from the saved queries CRUD view.

Expected results

The query tab should have the correct title of the saved query.

Actual results

The query tab is labeled as untitled.

Screenshots

Step 1: Save a query.

Step 2: Open SQL Lab in a new browser tab - see bug, the earlier saved query is Untitled.

Step 3: It got saved into the saved queries list in crud view

How to reproduce the bug

1. Go to SQL Lab
2. Write query and click on Save query
3. Open SQL in a new browser tab (or close existing tab and open SQL Lab again)
4. See issue - the earlier saved query is shown as unitled.

Environment

(please complete the following information):

• superset version: superset master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven’t found one similar.

Additional context

This is a regression, I noticed is couple days back first, it might have been introduced couple weeks back.

[hughhhh]

This PR has the fix: https://github.com/apache/superset/pull/12607

[yousoph]

Thanks @etr2460 ! Yeah, I think he was able to repro now so reopened the issue. I think the flag wasn’t set properly earlier so it looked like it wasn’t happening.