question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Tabs in dashboard columns

See original GitHub issue

problem / proposal For design reasons I’d like to nest tabs in columns.

context I implemented on a fork by moving onChangeTab to context. If this feature is desired I can fix tests, add nesting constraints, and PR. (Though idk if the nesting constraints are all that necessary)

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
micimizecommented, Nov 28, 2019

@mistercrunch would still like to PR this unless it is controversial. The live version of the gif above is live on the aqdc now

1reaction
micimizecommented, Sep 28, 2019

@mistercrunch dashboards. Tabs on master can only be top-level or nested within other tabs, and I’m proposing allowing deeper/less constrained nesting for building layouts such as:

tabs in column

Here’s a compressed diff of my current changes to superset/assets/src/dashboard/util/isValidChild.js (would of course refine the depth limits in an actual PR):

const parentMaxDepthLookup = {
   // ...
   [DASHBOARD_GRID_TYPE]: {
-    [TABS_TYPE]: depthOne,
+    [TABS_TYPE]: depthFive,
   },
   // ...
   [TABS_TYPE]: {
-    [TAB_TYPE]: depthTwo,
+    [TAB_TYPE]: depthFive,
   },

   [TAB_TYPE]: {
-    [TABS_TYPE]: depthTwo,
+    [TABS_TYPE]: depthThree,
   },

   [COLUMN_TYPE]: {
     // ...
+    [TABS_TYPE]: depthFive,
   },
   // ...
}
Read more comments on GitHub >

github_iconTop Results From Across the Web

Adding and organizing tabs on dashboards - IBM
To change the number of columns on a tab, open the tab menu by clicking the Down Arrow icon ( ), click Layout,...
Read more >
Tabs in dashboard columns #8303 - apache/superset - GitHub
For design reasons I'd like to nest tabs in columns. context. I implemented on a fork by moving onChangeTab to context. If this...
Read more >
Tabs in Dashboard - Sigma Community
I have a pivot table that has columns displaying % values and I was hoping for some way to toggle to show $...
Read more >
Add tabs and rows to a dashboard
Open a KPI Composer project and navigate to the Dashboard Visualization tab. · Select one of the dashboards in the tab. · Click...
Read more >
Dashboard layout - ArcGIS Online
The layout tree outlines the rows and columns that make up your dashboard, and the elements contained in them. A row describes elements...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found