Circular reference trying to decorate api_platform.swagger.normalizer.documentation

Hello,

I tried to decorate api_platform.swagger.normalizer.documentation, as seen here https://api-platform.com/docs/core/swagger/ and ran into a circular reference :

Circular reference detected for service "App\Swagger\SwaggerDecorator", path: "App\Swagger\SwaggerDecorator -> serializer -> App\Swagger\SwaggerDecorator".

Im using symfony4 and api-pack v1.0.1

services:
    App\Swagger\SwaggerDecorator:
        decorates: 'api_platform.swagger.normalizer.documentation'
        arguments: [ '@App\Swagger\SwaggerDecorator.inner' ]
        autoconfigure: false

namespace App\Swagger;

use Symfony\Component\Serializer\Normalizer\NormalizerInterface;

final class SwaggerDecorator implements NormalizerInterface
{
    private $decorated;

    public function __construct(NormalizerInterface $decorated)
    {
        $this->decorated = $decorated;
    }

    public function normalize($object, $format = null, array $context = [])
    {
        $docs = $this->decorated->normalize($object, $format, $context);


        return $docs;
    }

    public function supportsNormalization($data, $format = null)
    {
        return $this->decorated->supportsNormalization($data, $format);
    }
}

[emilien-puget]

I found the issue, the service was autowired, i moved the service declaration in service.yaml instead of an imported file

[ghost]

Hi @coldic3,

I think it is important to configure decorators after “_defaults” and “App” sections (autoconfigure + autowiring + src classes as services) into services.yaml file :

This configuration works :

# config/services.yaml

parameters:
    ...

services:
    # default configuration for services in *this* file
    _defaults:
        autowire: true      # Automatically injects dependencies in your services.
        autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.
        public: false

    # makes classes in src/ available to be used as services
    # this creates a service per class whose id is the fully-qualified class name
    App\:
        resource: '../src/*'
        exclude: '../src/{DependencyInjection,Kernel.php,Entity}'

    # Swagger Decorator
    App\Infrastructure\ApiPlatform\Swagger\SwaggerDecorator:
        decorates: 'api_platform.swagger.normalizer.documentation'

In your example, your external configurations were imported before “_defaults” section and it could not work.