Trying to register a schema which references twice the same complex type throws SchemaParseException

We’re using the dynamic schema registration of apicurio, and since the latest upstep, we’re facing the following error from time to time:

org.apache.avro.SchemaParseException: Can't redefine: com.xxx.yyy

Digging a bit deeper in the code, it seems this is a regression introduced in 2.2.2.Final (2.2.1 was still working). More specific here: https://github.com/Apicurio/apicurio-registry/blob/a28493615587946eb41b48fd778cf758e6129c71/serdes/avro-serde/src/main/java/io/apicurio/registry/serde/avro/AvroSchemaParser.java#L75 The resolvedReferences contains duplicates, which makes the schema.toString() crash.

I created a reproduction unit test. It tries to register the following schema:

{
  "namespace": "com.kubetrade.schema.trade",
  "type": "record",
  "name": "AvroSchemaF",
  "fields": [
    {
      "name": "schemaE1",
      "type": "com.kubetrade.schema.trade.AvroSchemaE"
    },
    {
      "name": "schemaE2",
      "type": "com.kubetrade.schema.trade.AvroSchemaE"
    },
    {
      "name": "key",
      "type": "string"
    }
  ]
}

However I don’t see exactly on how this should be fixed, can somebody assist with that?

PR: https://github.com/Apicurio/apicurio-registry/pull/2740

[TomBillietKlarrio]

I can confirm it works fine now in 2.3.0.Final, thanks for the fix.

[carlesarnal]

Ok, I understand now this issue better, thanks for the reproducer. The issue the other PR fixed is actually different. I have created https://github.com/Apicurio/apicurio-registry/pull/2775 that actually solves this issue, thanks!