Don't allow specify undefined property as required in schema

Versions

• Node.js: 8.12.0
• swagger-parser: 6.0.2

Code example

API specification:

openapi: '3.0.2'
info:
  version: v1
  title: test
paths:
  /:
    post:
      requestBody:
        required: true
        content:
          'application/json':
            schema:
              type: object
              properties:
                foo:
                  type: string
              required:
                - foo
                - bar # This property is not defined!
              additionalProperties: false
      responses:
        200:
          description: Success

const SwaggerParser = require('swagger-parser');

SwaggerParser.validate('api.yml')
  .then((api) => console.log('done'))
  .catch((err) => console.error(err));

Expected behavior

Validation error: property bar is required, but it’s not defined.

Actual behavior

No errors.

[jdegre]

Just to understanda the issue… why the schema in the OP is supposed to be wrong?? In my view, the schema is correct, and it simply says that property “bar” is required, and must always be present in the response, but the schema does not constrain what type it can take. “bar” can be an integer, a string, an object… whatever.

[stueynz]

Fixed in https://github.com/APIDevTools/swagger-parser/pull/179 - All the spec consistency checks were only used to work on Swagger 2.0 specs; All fixed now for OpenAPI v3.0 specs; Might get a chance to look into v3.1 changes later.