client.resetStore on logout is wrong

https://github.com/apollographql/apollo-client/blob/master/docs/source/recipes/authentication.md#reset-store-on-logout

The documentation says that you should use client.resetStore() on logout, but that is wrong. If you do that, then the queries get refetched and cached with User A’s permissions and then when User B logs in, the query is already fetched and cached, so it doesn’t fetch data again, and instead it shows User A’s data to User B because it’s in the cache.

Either a new function called clearStore() needs to be created or the documentation should be updated to say that localStorage.clear() (or whatever methodology you’re using to persist data locally’s clear out function).

[bogdansoare]

also having this issue. Agree that we need a clearStore() function, because after logout (removing the auth token) and calling client.resetStore() the refetched queries throw errors because the lack of authorization

[blacklakeDev]

@fenos tried your method didn’t work.

Seeing the same problem here.

Intended: errors resulting from UserA’s queries should be cleared out on client.resetStore()

Actual: User B component props show errors from userA’s queries

Query from User A returns an error in data, as expected. { error: { graphQLErrors: [ { Error: <message from User A>} ] } } However, after client.resetStore, User B still sees: { error: { graphQLErrors: [ { Error: <message from User A>} ] } } I dug in deeper and saw that the errorLink from UserB didn’t return any error, so the Error must have been read from cache. Then I console.log the cache from before and after resetStore and found that store data was cleared. Makes no sense. Anyone else has a clue?