Graphql requests are not monitoring friendly

Intended outcome:

Be able to monitor graphql requests through a third party monitoring library.

Actual outcome:

Third party monitoring library override global fetch to gather data on each request. Since createHttpLink keep a reference to fetch (code), if global fetch is instrumented after createHttpLink execution then graphql requests can’t be instrumented.

How to reproduce the issue:

with a simple fetch override:

const originalFetch = window.fetch;
window.fetch = function () {
  console.log("request instrumented", arguments[0]);
  return originalFetch.apply(this, arguments);
};

if executed before ApolloClient initialization, graphql requests are logged if executed after ApolloClient initialization, graphql requests are not logged

Versions

master

[arminrosu]

That’s also interesting and something that might be worth getting more detail on - what issues did you see? Is this a bug in Apollo Client?

I’ll get back to you once I give this one another shot. I haven’t had time to look into it closely yet.

[bignimbus]

Hi @bcaudan, thanks for your patience! Would passing the overridden fetch function via the fetch option in HTTP Link per these docs address the issue you’re describing?