Nested fragment results arent't merged into a query result

When a fragment selects nested fields and the original query also selects fields on that type, the fields from the fragment are left out and only the ones from the query are in the result.

Intended outcome:

The results from the nested fields of the fragment should be merged into the complete result.

Actual outcome:

The nested fields are left out.

How to reproduce the issue:

Here’s a query that can be run in Githunts’ GraphiQL. Notice that login as well as avatar_url is available in the result.

When the same query is run with apollo-client, only avatar_url is available in the result.

Here’s a node script that shows the issue:

require('isomorphic-fetch');
const {default: ApolloClient, createNetworkInterface} = require('apollo-client');
const gql = require('graphql-tag').default;

const client = new ApolloClient({
  networkInterface: createNetworkInterface({uri: 'http://www.githunt.com/graphql'})
});

const query = gql`
fragment RepositoryData on Repository {
  owner {
    login
  }
}

{
  feed(type: NEW, limit: 5) {
    repository {
      ...RepositoryData
      name
      owner {
        avatar_url
      }
    }
  }
}
`;

const promise = client.query({query}).then(({data}) => {
  console.log(JSON.stringify(data));
}, e => {
  console.error(res);
});

[ksmth]

if you change

repository {
  ...RepositoryData
  name
  owner {
    avatar_url
  }
}

to read like this:

repository {
  name
  owner {
    avatar_url
  }
  ...RepositoryData
}

it works. This also works for as many fragments in any order, so it seems for now it’s best to always put them last.

[stubailo]

Note that this issue is now fixed as of graphql-anywhere 3.1.0