queryDeduplication not working as expected in apollo-client@2.0

Intended outcome:

The same graphQL query (same variables and query string), executed by different components on load of the app, should only result in one network request (visible in the network tab). Before upgrading to apollo-client 2.0, we would experience such behavior.

Actual outcome:

Now that we have upgraded to apollo-client 2.0 we see a network request for every time we execute a query.

The following code is what we have implemented using apollo-client 2.0 and shows 2 network requests in the network tab. Please note that we are not mentioning queryDeduplication since it is supposed to be set to true by default:

import ApolloClient from 'apollo-client';
import { InMemoryCache } from 'apollo-cache-inmemory';
import { createHttpLink } from 'apollo-link-http';

import QUERY from 'gql/queries/query.js';

const client = new ApolloClient({
  cache: new InMemoryCache(),
  link: createHttpLink({ uri: '/graphql' })
});

client.watchQuery({
  // I've tried every fetch-policy except "cache-only"
  // just to see if any would actually dedup requests
  fetchPolicy: 'cache-and-network',
  query: QUERY,
  variables: { id: 'abcd' }
}).subscribe({
  error: error => {
    throw new Error (error);
  }
});

client.watchQuery({
  fetchPolicy: 'cache-and-network',
  query: QUERY,
  variables: { id: 'abcd' }
}).subscribe({
  error: error => {
    throw new Error (error);
  }
});

Version

• apollo-client@2.0.1
• apollo-cache@1.0.0
• apollo-cache-inmemory@1.0.0
• apollo-link-http@1.0.0
• graphql@0.11.7
• graphql-tag@2.4.2

Thanks for your help!

[jbaxleyiii]

@manbropig @Wenzil @malexandre this is first up on my bug squashing adventure this week!

Sorry for the delay, after the 2.0 launch + new sites + graphqlsummit, we took a week off at our company for a company wide hack week. I’m back on Apollo this week and am making a few milestones to work through. This is priority number one for me

[jbaxleyiii]

The new dedup link will be part of the next release!