Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

skip option fails when assigned a variable that flips from false to true

See original GitHub issue

Intended outcome:

skip: true results in no network request. The error property in the result of the useQuery hook reflects the current running query.

Actual outcome: skip: true results in a network request. The error property displays for the previous result.

How to reproduce the issue:

Go here: https://codesandbox.io/s/apolloclient-v3-skip-bug-ov1z3?file=/src/app.js
Click the button and observe the 400 from the graphql endpoint.
Click the button again and observe the successful response but the logged error message.

Versions

Issue Analytics

State:
Created 3 years ago
Reactions:6
Comments:19 (2 by maintainers)

Top GitHub Comments

14reactions

hwillsoncommented, Jul 31, 2020

We’re finalizing a fix for this and other skip related issues, and should have it ready today.

6reactions

cdaz5commented, Jul 23, 2020

i’m surprised the major release (out of beta) was done with this still broken (since it was a known thing not a bug that popped after release)… it’s a pretty widely used feature and I was a little shocked after I migrated to find the console error and this thread … would of been nice if it was a known thing to make mention of it in the release/migration guide … maybe its just me though?