subscribeToMore bad documentations and typescript type annotations

Intended outcome: According to new docs about subscriptions: https://www.apollographql.com/docs/react/features/subscriptions.html#subscribe-to-more

Data about new comment should be found in subscriptionData.data.commentAdded

Typescript annotation for subscriptionData is subscriptionData: { data: any }

Actual outcome: But data about new comment are direcetly in subscriptionData like this: subscriptionData.commentAdded

Typescript annotation for subscriptionData should be according to data something like subscriptionData: any

How to reproduce the issue: Try subscription example from docs.

Version

• apollo-client@<2.0.1>
• react-apollo@<2.0.0>

[jbaxleyiii]

Looking at the olds docs (https://s3.amazonaws.com/apollo-docs-1.x/subscriptions.html#subscribe-to-more) subscribeToMore should return { data, errors }. Therefore I think this was a bug that I introduced in the 2.0 and should be fixed as such!

If anyone wants to open a PR I’d be thrilled to review and merge, otherwise I will add it to my list for this week.

Thanks to @dnalborczyk , @DxCx and @cesarsolorzano for chiming in here and to @JozefBiros for opening this issue!

[dnalborczyk]

@DxCx I’m not quite sure if I’m following. I’m mainly wondering if the above change was intended, which is fine with me, other than the docs seem to be wrong - or otherwise it might need to be fixed before a broader adoption of v2.0.