Uncaught error when network connection is disrupted.

Intended outcome:

I’d like to be able to catch errors when a network connection is disrupted.

Actual outcome:

Errors generated when a network connection is disrupted result in an uncaught error: Uncaught (in promise) Error: undefined

How to reproduce the issue:

On a basic working example of an apollo app, disable the network connection in the browser or turn wifi off.

Versions

  System:
    OS: macOS 11.4
  Binaries:
    Node: 14.16.1 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 8.5.5 - /usr/local/bin/npm
  Browsers:
    Chrome: 101.0.4951.64
    Firefox: 100.0.2
    Safari: 14.1.1
  npmPackages:
    @apollo/client: ^3.6.4 => 3.6.4 

[pei-wang]

I encountered this issue too. I mocked a 500 error response for my API call.

I am wondering what’s the appropriate approach for handling this. it does not causes any issue on my functionality, just the error on ReactRefreshWebpackPlugin overlay is annoying me. I can catch the error where I invoke the query, but it makes me replicate the catch to everywhere I use query/mutation.

Was trying to create a custom link to prevent the error pass back since I already handled it on Error link. but it doesn’t work, since the Apollo client expects the result(error) back.

index.js:29 Uncaught (in promise) Error: Response not successful: Received status code 500
    at new ApolloError (index.js:29:1)
    at Object.error (QueryManager.js:141:1)
    at notifySubscription (module.js:137:1)
    at onNotify (module.js:176:1)
    at SubscriptionObserver.error (module.js:229:1)
    at Object.error (asyncMap.js:32:1)
    at notifySubscription (module.js:137:1)
    at onNotify (module.js:176:1)
    at SubscriptionObserver.error (module.js:229:1)
    at iteration.js:4:1
    at Array.forEach (<anonymous>)
    at iterateObserversSafely (iteration.js:4:1)
    at Object.error (Concast.js:37:1)
    at notifySubscription (module.js:137:1)
    at onNotify (module.js:176:1)
    at SubscriptionObserver.error (module.js:229:1)
    ```

[jpvajda]

@jdgreenberger no updates as of yet. Our team is working on some higher priority things at the moment. Though we accept PRs so if you want to make an attempt to improve the error message here, we’d be happy to review the PR. Just let us know!