Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

useMutation is not calling the latest version of onCompleted

See original GitHub issue

Intended outcome:

I set an onCompleted callback funcA for useMutation, funcA depends on state, when I fetch and modify the state, onCompleted still calls the old version of funcA. Actual outcome:

How to reproduce the issue:

https://codesandbox.io/s/usemutation-example-ke17zm?file=/src/index.jsx

click the add person button, expected to log after click in console but before click

Versions

3.6.3

Issue Analytics

State:
Created a year ago
Comments:8 (1 by maintainers)

Top GitHub Comments

4reactions

charle692commented, May 19, 2022

Alright, fixed the issue in the linked ^ PR. I’ve confirmed in my application that is does indeed fix the issue but if you all have the chance to try it out on your end that would be appreciated 😃

3reactions

glenndixoncommented, May 16, 2022

@nathanmarks Check out this: https://github.com/apollographql/apollo-client/blob/main/src/react/hooks/useQuery.ts#L280

I haven’t tested but my interpretation based on the comment and code there is that useQuery DOES use the “latest” version of the options i.e. it stores the options in a ref which updates on every render.

So I think there IS an inconsistency here between useMutation and useQuery, which suggests to me some remediation is called for.