apollo-datasource-rest parseBody better check json

Hi. I noticed that apollo-datasource-rest parse my response’s body as text. I checked with the source code, and this is how the library is currently checking:

  protected parseBody(response: Response): Promise<object | string> {
    const contentType = response.headers.get('Content-Type');
    if (
      contentType &&
      (contentType.startsWith('application/json') ||
        contentType.startsWith('application/hal+json'))
    ) {
      return response.json();
    } else {
      return response.text();
    }
  }

I was able to override that by changing the if condition with contentType.includes("json"). I wonder if we want to change the library itself, since there are APIs that respond with different content type header.

My use case is Contentful API, which return application/some-contentful-meta-data+json

[abernix]

This has been discussed recently on https://github.com/apollographql/apollo-server/pull/1645#issuecomment-439370832.

As parseBody is a protected method (that is to say, it can be implemented by any class which extends RESTDataSource), developers are free to implement override its default behavior in any way they’d like — including and up to allowing any Content-Type which contains json as necessitated above:

class DogAPI extends RESTDataSource {
  constructor() {
    super();
    this.baseURL = "https://dog.ceo/api/";
  }

  parseBody(response) {
    if (response.headers.get('Content-Type').includes('json')) {
      return response.json();
    } else {
      return response.text();
    }
  }

  /* ... custom RESTDataSource methods ... */
}

Also, if we were to go the route of jsonContentTypes, we’d quickly end up with a long laundry list of other content-types (e.g. xmlContentTypes, protobufContentTypes, etc.).

I believe this provides the best abstraction without overlooking specific implementation details (and often time, meaningful differences) between various content types which might appear similar on the surface.

[vincent-vade]

This has been discussed recently on #1645 (comment).

As parseBody is a protected method (that is to say, it can be implemented by any class which extends RESTDataSource), developers are free to implement override its default behavior in any way they’d like — including and up to allowing any Content-Type which contains json as necessitated above:

class DogAPI extends RESTDataSource {
  constructor() {
    super();
    this.baseURL = "https://dog.ceo/api/";
  }

  parseBody(response) {
    if (response.headers.get('Content-Type').includes('json')) {
      return response.json();
    } else {
      return response.text();
    }
  }

  /* ... custom RESTDataSource methods ... */
}

Also, if we were to go the route of jsonContentTypes, we’d quickly end up with a long laundry list of other content-types (e.g. xmlContentTypes, protobufContentTypes, etc.).

I believe this provides the best abstraction without overlooking specific implementation details (and often time, meaningful differences) between various content types which might appear similar on the surface.

Thank’s