apollo-server-lambda with async resolvers callback too early in lambda nodejs10x runtime

We’ve upgrade our lambda runtime to the nodejs10.x (from nodejs8.x). After doing this our resolvers started returning almost immediately without awaiting (e.g. they returned with a body of null).

We had been using the documented way of returning createHandler:

export const handler = server.createHandler({
  cors: { origin: '*' },
});

However now, as a workaround, we’re using (as inspired by #2179):

import { ApolloServer } from 'apollo-server-lambda';
import resolvers from './resources/resolvers';
import typeDefs from './resources/typeDefs';

const server = new ApolloServer({
  typeDefs,
  resolvers,
  context: ({ event, context }) => {
    logger.debug(event);
    return { event, context };
  },
});

function runApollo(event, context, apollo) {
  return new Promise((resolve, reject) => {
    const callback = (error, body) => (error ? reject(error) : resolve(body));
    apollo(event, context, callback);
  });
}

export async function handler(event, context) {
  const apollo = server.createHandler({ cors: { origin: '*' } });
  const response = await runApollo(event, context, apollo);
  return response;
}

As an initial diagnostic it looks like the way server.createHandler tries to avoid breaking the previous contract by wrapping its async construction in a sync one no longer works in Node 10.

node: 10.15.3 apollo-server-lambda: 2.4.8

[ryan-mars]

Thank you for posting this. I was up till 4am last night trying to diagnose this issue. I thought it was me.

[JacksonKearl]

Is this fixed with the closing of awslabs/aws-serverless-express#234?