`didEncounterErrors` is not triggered when an error occurs in `context` creation.

Bug

@abernix edits: The didEncounterErrors life-cycle hook is not invoked when errors occur within context creation. That shouldn’t be the case!

Original feature request

As of version 2.9.0, there is no lifecycle event to handle manually errors encountered in the context creation process.

Suggestion:

const server = new ApolloServer({
  context: () => { throw new Error('Ouch!') },
  plugins: [
    {
      requestDidStart: () => ({
        contextCreationDidFail: (error) => {
          // do something here?
        },
      })
    },
  ],
})

[spencerwilson]

Want to offer a use case:

If you have error-prone code in your context function

We do! In fact, it was inspired by the guidance in “API-wide authentication”. Our GraphQL API serves only confidential data and privileged mutations, so denying all requests that lack valid authentication is appealing to us.

[abernix]

The naming is a bit confusing but requestContext is representative of Apollo Server (the framework’s) context, not the user’s context. Put another way, the requestContext has a property on it called context, which is the actual context that the end-user creates within the context function.

To me, it sounds like a bug that didEnounterErrors is not invoked when there is a user-context creation error, and it seems that we should consider addressing that. Therefore, I’ve adjusted this feature request to an issue, accordingly.