proposal: [apollo-datasource-rest] - bypass redis cache while redis host is not reachable

If Redis host is down, i.e. not reachable, the query response gets this error:

 "message": "Reached the max retries per request limit (which is 3). Refer to \"maxRetriesPerRequest\" option for details."

However, I think that showing this kind of error should be avoided and the default response’s flow should be granted.

In https://github.com/apollographql/apollo-server/blob/master/packages/apollo-datasource-rest/src/HTTPCache.ts line 38 will assign the ioredis’ error to entry.

...
const entry = await this.keyValueCache.get(cacheKey);
    if (!entry) {
      const response = await this.httpFetch(request);
      ...

I guess entry should be null in that case so that const response = await this.httpFetch(request); can be executed if redis’ host is down.

[ecerroni]

@geraldstrobl Nope, no PR.

This issue is been waiting for a response from the team. Still nothing.

I guess it is not a high priority.

[timsuchanek]

In case you want to save yourself all of this overhead, here a shameless plug: I built https://graphcdn.io, which takes care of the caching for you. I promise you, that you won’t hit these limitations there. You won’t need to host any Redis with that anymore.