Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

RESTDataSource has double caching

See original GitHub issue

It stores all caches in cache implementation InMemory, Redis, Memcache and also in Map object. Second time if you send same request it will return the cache value from the Map. This will override ttl config. Not sure also how this is safe, in terms of memory, how big the map object will be if it stores all responses.

Issue Analytics

State:
Created 5 years ago
Comments:10 (5 by maintainers)

Top GitHub Comments

6reactions

martijnwalravencommented, Aug 13, 2018

@uarsovic Yeah, that’s not how data sources are meant to be used. You should export the class from your other module and instantiate it in the dataSources function.

Sharing a data source between requests will be guaranteed to lead to trouble, because it means you don’t have access to the current request’s context through this.context for example. And we plan on extending data sources with more features that require them to be bound to a request, like tracing of backend calls.

0reactions

roman-16commented, Jul 23, 2019

I think this should be somehow documented, I had the same problem.