unable to compile TS app - missing @types/type-is apollo-server-express

After installing apollo-server-express and running tsc to compile the app i get the following error:

Error: Command failed with exit code 2: ./node_modules/.bin/tsc -p tsconfig.build.json
node_modules/apollo-server-express/src/ApolloServer.ts(20,20): error TS7016: Could not find a declaration file for module 'type-is'. '/Users/fabriziofenoglio/Documents/gg/node_modules/type-is/index.js' implicitly has an 'any' type.
  Try `npm install @types/type-is` if it exists or add a new declaration (.d.ts) file containing `declare module 'type-is';`
    at makeError

I can manually solve this by installing @types/type-is but, this surely should be included in the devDependencies of apollo-server-express

apollo-server-express version: ^2.9.16

[bwlt]

Hi, this is a reproduction of the above error: https://github.com/bwlt/apollo-server/tree/repro-3691 I’m having the same issue. The scenario is:

// main.ts
import { ApolloServer } from "apollo-server";
import { context } from "./context";
import { typeDefs } from "./schema";
import { resolvers } from "./resolvers";
import { mocks } from "./mocks";

const server = new ApolloServer({
  typeDefs,
  resolvers,
  context,
  mocks: process.env.NODE_ENV === "production" ? undefined : mocks,
});

// context.ts
import { ExpressContext } from "apollo-server-express/src/ApolloServer";

export interface Context extends ExpressContext {
  ...
}

export const context: ContextFunction<
  ExpressContext,
  Context
> = function context(expressContext) {
  ...
}

The problem occurs when I import { ExpressContext } from “apollo-server-express/src/ApolloServer”.

Replacing

import { ExpressContext } from "apollo-server-express/src/ApolloServer";

with

import { ExpressContext } from "apollo-server-express/dist/ApolloServer";

will fix the issue

[glasser]

Importing from package/src/somefile or package/dist/somefile is not officially supported. We do our best to choose what gets exported from the top level of a package and everything inside is an implementation detail. (Some other Apollo projects like Apollo Client explicitly set up deeper exports, but Apollo Server doesn’t.)

The symbol in question ExpressContext has been exported from apollo-server-express since v2.19.2, so you can now just do import { ExpressContext } from 'apollo-server-express' and it should just work. (I looked at the reproduction, upgraded it to v2.19.2 and changed the import line, and it worked. It also works with 3.3.0.)

@shellscape , are you running into this with the same symbol or a different one?